SNOW-1649780: Bug fix Series.sort_values fails when name overlaps with index name #2291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In native pandas, calling sort_values where column name overlaps with index name raises error
ValueError: 'col' is both an index level and a column label, which is ambiguous
. But this works for series.In Snowpark pandas we were raising errors both the scenarios Dataframe (this is expected) and Series (this was bug).
Root cause: In modin frontend we to implement Series.sort_values we convert this to Dataframe and call sort_values on it. So this failed the validation above.
Fix: Instead of converting Series to Dataframe directly call
query_compiler.sort_rows_by_column_values
.